Expose EditorExport through the EditorInterface singleton
#98251
+124
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also exposed functions relating to feature tags of platforms and presets.
allenwp
force-pushed
the
Expose-EditorExport-through-EditorInterface
branch
from
13e996f
to
e501c12
Compare
AThousandShips
changed the title
EditorExport through the EditorInterface singletonEditorExport through the EditorInterface singleton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed
EditorExportthrough theEditorInterfacesingleton. Also exposed functions relating to feature tags of platforms and presets.Background
Retrieving feature tags in a way similar to the export process is needed to implement my "Resource Remaps" proposal as an
EditorExportPlugin. This PR exposes the parts ofEditorExportthat are required to do this.Related PRs
Export scripting functionality: #90782
Feature tags in scripting: #86747
Implementation
I have kept the scripting API similar to the C++ API, but that does mean there are some style differences between getting custom features (existing function that returns a comma delimited
String) and getting the platform/preset features (new functions that return aTypedArray<String>).In addition to the functions I've exposed in this PR, the currently
protectedEditorExportPlatform::get_featuresfunction could be exposed to give developers a feature list that is true to the final list of features used during the export process. I did not include this function only because it is currentlyprotected, but if it others believe it should be changed topublic, then it would be nice to expose it.